Watch all namespaces by default #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBarendse
commented
May 14, 2021
SimonBarendse
force-pushed
the
feature/watch-namespaces-default
branch
from
15dcdc4
to
91a396f
Compare
When nothing is configured, watch all namespaces by default. This makes it easier to get started. It also makes configuring to watch all namespaces less akward (currently you have to set the WATCH_NAMESPACE environment variable to the empty string to configure the operator to watch all namespaces.
SimonBarendse
force-pushed
the
feature/watch-namespaces-default
branch
from
91a396f
to
859c9e3
Compare
jillianwilson
approved these changes
May 19, 2021
|
We should update the Helm chart as well to reflect this, because it overrides this setting. |
|
Thanks Floris! I've opened 1Password/connect-helm-charts#54 for the follow up in the Helm chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nothing is configured, watch all namespaces by default. This makes it easier to get started.
It also makes configuring to watch all namespaces less awkward (currently you have to set the
WATCH_NAMESPACEenvironment variable to the empty string to configure the operator to watch all namespaces.Inspired by #8 and replaces #39.