Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret references do not open correctly in desktop app #128

Closed
jodyheavener opened this issue Mar 8, 2023 · 2 comments
Closed

Secret references do not open correctly in desktop app #128

jodyheavener opened this issue Mar 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jodyheavener
Copy link
Member

Your environment

op-vscode version: 1.0.4

VS Code version:

CLI version: 2.13.1

Desktop app version: 1Password for Mac 8.10.2 (81002004)

Steps to reproduce

  1. Open an .env file
  2. Add a secret reference for an API Credential, made up of of UUIDs for vault and item
  3. Command-click on the secret reference

What happened?

1Password desktop opens, but the item is not selected

What did you expect to happen?

The item is selected (made visible)

@jodyheavener jodyheavener added the bug Something isn't working label Mar 8, 2023
@jodyheavener
Copy link
Member Author

I believe this issue still occurs, but possible not reliably. More investigation is required. It will be worth looking into how we construct and open URLs under the 1Password schema.

@jodyheavener jodyheavener added the hacktoberfest This issue is open to submissions from Hacktoberfest participants label Oct 3, 2023
@jodyheavener jodyheavener removed the hacktoberfest This issue is open to submissions from Hacktoberfest participants label Apr 8, 2024
@jodyheavener
Copy link
Member Author

This will still occasionally happen, but in my most recent test it appears to be working correctly in macOS and Windows. I am going to close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant