Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow patterns for secret detection to be customized #171

Open
jodyheavener opened this issue Sep 21, 2023 · 0 comments · May be fixed by #178
Open

Allow patterns for secret detection to be customized #171

jodyheavener opened this issue Sep 21, 2023 · 0 comments · May be fixed by #178
Labels
enhancement New feature or request

Comments

@jodyheavener
Copy link
Member

Summary

We maintain a list of regular expressions to help detect secrets within your open files in VS Code. There will always be room to expand this list, and in some the extension may encounter a false positive. It would be nice if an individual could customize this list to not disable certain patterns, but add their own pattern.

Use cases

  • User regularly works in code that results in false positives for a specific secret pattern, and disables it as a result so it does not impact their development workflow
  • User works for a company that has a special type of token known only to them. They add a pattern to match this token.

Proposed solution

Add two new settings:

  • One storing and listing disabled patterns by name
    • The ability to disable a pattern should be presented as a CodeLens next to the existing CL offering to save. For example "Save in 1Password • Ignore pattern"
  • One storing custom pattern regexps
    • The settings will hold the patterns, which will be merged into the existing pattern list
    • Possibly include an option to store a name and field alongside the pattern that is suggested as the item and field values

Is there a workaround to accomplish this today?

No

@jodyheavener jodyheavener added the enhancement New feature or request label Sep 21, 2023
@jodyheavener jodyheavener added the hacktoberfest This issue is open to submissions from Hacktoberfest participants label Oct 3, 2023
@dethancosta dethancosta linked a pull request Oct 17, 2023 that will close this issue
@jodyheavener jodyheavener removed the hacktoberfest This issue is open to submissions from Hacktoberfest participants label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant