Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read properties of undefined (reading 'reference') #69

Closed
thiagotsn opened this issue Aug 26, 2022 · 8 comments · Fixed by #82
Closed

Cannot read properties of undefined (reading 'reference') #69

thiagotsn opened this issue Aug 26, 2022 · 8 comments · Fixed by #82
Assignees
Labels
bug Something isn't working

Comments

@thiagotsn
Copy link

thiagotsn commented Aug 26, 2022

Your environment

op-vscode version: 1.0.1

VS Code version: 1.70.2 (Apple Silicon)

CLI version: 2.6.2

OS: macOS Monterey v12.5.1

Steps to reproduce

When using the Save in 1Password feature in the command palette or json file.

  1. Select a secret
  2. ⌘+⇧+P
  3. Select 1Password: Save in 1Password
  4. Enter a name: MyEntry
  5. Enter field name: password
  6. Use TouchID to allow 1Password

What happened?

A notification with: Cannot read properties of undefined (reading 'reference')
An entry in 1Password is created with just the title and without the secret.

What did you expect to happen?

Saving the secret in 1Password entry.

Notes & Logs

[2022-08-26 15:34:40.657] [exthost] [error] TypeError: Cannot read properties of undefined (reading 'reference')
at /Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:6016
at Object.edit (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:54197)
at Ct.insertSavedItem (/Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:5994)
at Ct.saveItem (/Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:4340)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at /Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:2298
at a._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:63914)
at a._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:63914) op-vscode.saveValueToItem {"value":"1Password.op-vscode","_lower":"1password.op-vscode"}
[2022-08-26 15:34:40.658] [exthost] [error] TypeError: Cannot read properties of undefined (reading 'reference')
at /Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:6016
at Object.edit (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:54197)
at Ct.insertSavedItem (/Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:5994)
at Ct.saveItem (/Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:4340)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at /Users/thiago/.vscode/extensions/1password.op-vscode-1.0.1/dist/extension.js:53:2298
at a._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:63914)
at a._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:85:63914) _vscode_delegate_cmd_l7akmsrm undefined

CleanShot 2022-08-26 at 15 32 41@2x

@thiagotsn thiagotsn added the bug Something isn't working label Aug 26, 2022
@meSingh
Copy link

meSingh commented Sep 9, 2022

Also, getting this error

+1

@johnypony3

This comment was marked as off-topic.

@meSingh

This comment was marked as off-topic.

@johnypony3

This comment was marked as off-topic.

@jodyheavener
Copy link
Member

Hi folks, thanks for raising this issue. I haven't yet been able to identify the root cause, but I'm hoping to spend more time on it shortly here.

@jodyheavener
Copy link
Member

Hey all, just wanted to follow up to note that I'm able to replicate this issue now, and it looks related to newer versions of the CLI. You could try downgrading to an older version in the meantime, but that's not ideal, and at any rate I'll be getting a fix out as soon as possible. I'll update this thread once a fix is out. Thanks for your patience.

@jodyheavener jodyheavener self-assigned this Sep 22, 2022
@johnypony3
Copy link

johnypony3 commented Sep 26, 2022

thank you for the update @jodyheavener

@jodyheavener
Copy link
Member

v1.0.2 of the extension is rolling out now, which should address this issue. Please let me know if you continue to encounter it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants