Introduce Google Cloud Run deployment example #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
- must be quoted Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
- don't scale to 0 - faster boot time Signed-off-by: Adam Pike <adam.pike@1password.com>
- must total 1 vCPU Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
- shorter name - add subfolder and YAML spec for connecting to Google Workspace Signed-off-by: Adam Pike <adam.pike@1password.com>
- most ToC entries are missing - GW section is missing some steps - needs appendices to cover updates, scaling, cred rotation, etc. Signed-off-by: Adam Pike <adam.pike@1password.com>
ag-adampike
force-pushed
the
solutions/pike/google-cloud-run
branch
from
abc8076
to
a4b4c19
Compare
Signed-off-by: Adam Pike <adam.pike@1password.com>
- fix alert rendering Signed-off-by: Adam Pike <adam.pike@1password.com>
- remove indents for quote blocks used for alerts to enable rich rendering Signed-off-by: Adam Pike <adam.pike@1password.com>
black-bryan
reviewed
Apr 30, 2024
black-bryan
reviewed
Apr 30, 2024
|
Thanks for the look! I've got some local work that is almost ready to commit that resolves a bit of this already. 🙂 |
- completed steps to enable Workspace - incorporated review suggestions - typos/corrections Signed-off-by: Adam Pike <adam.pike@1password.com> Co-Authored-By: Bryan Black <bryan.black@agilebits.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
- add README.md to google-workspace subdir - remove GW instructions from main README - add callout to link out to GW instructions in new README Co-Authored-By: Bryan Black <bryan.black@agilebits.com>
- shorter, better tooltip for GW steps - migrated info from tooltip to GW README Signed-off-by: Adam Pike <adam.pike@1password.com>
- functions corretly either way - aligned with indent structure for lists elsewhere in this file and repo Signed-off-by: Adam Pike <adam.pike@1password.com>
- fix broken relative links introduced in last commit - punctuation Signed-off-by: Adam Pike <adam.pike@1password.com>
- ToC - prereq steps Signed-off-by: Adam Pike <adam.pike@1password.com>
black-bryan
reviewed
May 3, 2024
ag-adampike
commented
May 3, 2024
- added updated instructions - style (case) Co-authored-by: Bryan Black <bryan.black@agilebits.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Co-Authored-By: Bryan Black <bryan.black@agilebits.com>
ag-adampike
force-pushed
the
solutions/pike/google-cloud-run
branch
from
c6f25e0
to
39694ef
Compare
Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
black-bryan
previously approved these changes
May 8, 2024
|
All links should be pointing the their new home on |
- fixed some broken links - corrected typos - slightly shorter code block for secret access command - clearer update steps - DRY-er post-update testing - better callouts Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
black-bryan
approved these changes
May 9, 2024
| ```sh | ||
| gcloud secrets add-iam-policy-binding scimsession --member=serviceAccount:$( | ||
| gcloud iam service-accounts list --filter="$( | ||
| gcloud projects describe op-scim-bridge --format="value(projectNumber)" |
There was a problem hiding this comment.
We might want to add a tip here, stating that if they used a custom project name to edit this command.
As an alternative to a tip, we could set a opProject variable as part of the command used in step 1.2 and the tip in step 1.2 for customers who already created a project. This way we could simply use that within this long command to remove any confusion.
There was a problem hiding this comment.
Great point, and I think we can likely improve the flow a bit in that earlier step and perhaps replace this entire line in this block with that variable.
Let's merge this as is and then I'll note it in a new issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to establish a new Cloud Run deployment example for SCIM Bridge, including:
For review:
/beta/google-cloud-run/README.md/beta/google-cloud-run/google-workspace/README.md