Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to env var provisioners for ngrok #216

Closed
AndyTitu opened this issue Mar 23, 2023 · 1 comment · Fixed by #222
Closed

Switch to env var provisioners for ngrok #216

AndyTitu opened this issue Mar 23, 2023 · 1 comment · Fixed by #222

Comments

@AndyTitu
Copy link
Contributor

Platform or tool

Ngrok

Desired or expected behavior

Authtoken and api key can be provisioned via the newly exposed env vars NGROK_AUTH_TOKEN and NGROK_API_KEY.

We need to realise that NGROK_API_KEY was recently introduced so maybe not all ngrok users will benefit from this yet. We should consider defining a versionChecker inside our plugins that would only allow the plugin to be run if the user's ngrok version is above a certain threshold.

Current behavior

Ngrok provisions secrets using the config file. This is not as straightforward as provisioning via env vars because it involves handling already existing non-sensitive config files. It requires logic for looking at default locations as well looking at --config flag. The case when multiple config flags are specified is not supported because the merging behaviour does not fit with our FIFO file provisioning.

Relevant log output

No response

op CLI version

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants