Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential store that can be referenced by connections #89

Closed
d0pang opened this issue Feb 23, 2021 · 8 comments
Closed

Credential store that can be referenced by connections #89

d0pang opened this issue Feb 23, 2021 · 8 comments
Assignees
Labels
general-supportive Involves supportive infrastructure or tools meta-feature New feature
Milestone

Comments

@d0pang
Copy link

d0pang commented Feb 23, 2021

Can you move account and password into the configuration page for management?
User can configure multiple account and password, and then we only need to select which account to use when configuring the server info.

Because most of us use the same account, and the password of the account is usually modified regularly in the enterprise, so it is much more convenient to modify each time.


能不能把账号密码放到配置界面管理, 可以配置多个账号密码, 然后在服务器配置的时候只需要选择使用哪个账号就好.
因为我们大部分用的都是同一个账号, 而账号的密码在企业一般是要定期修改的, 这样每次修改就方便多了.

@d0pang d0pang added the meta-enhancement Enhacement of existing feature label Feb 23, 2021
@majkinetor
Copy link
Member

majkinetor commented Feb 23, 2021

English please ?

As far as google translate does it right, this is basically variant of #73 or list of users on connection discussed here.

Do you mean that you would like to have some kind of extra menu that shows the list of users

Having just a list of global credentials without connection coupling sounds like solid idea too,

@d0pang

This comment has been minimized.

@majkinetor majkinetor added meta-feature New feature general-supportive Involves supportive infrastructure or tools and removed meta-enhancement Enhacement of existing feature labels Feb 23, 2021
@majkinetor majkinetor changed the title 账号密码统一管理 Credential store that can be referenced by connections Feb 23, 2021
@majkinetor
Copy link
Member

Thanks @d0pang .

Can you move account and password into the configuration page for management?

Moving is definitely not good option as some connections are coupled to credentials.

Because most of us use the same account, and the password of the account is usually modified regularly in the enterprise, so it is much more convenient to modify each time.

I see, so this can be solved via several different ways, one of which is mass editing accompanied with good filtering capabilities - you could for example select all connections using specific username and mass edit the password. The speed up is about the same as in separated credentials list and functionality is way more useful. This is proposed already somewhere... I'll have to create a ticket for it, can't find it.

One problem with credential list is that it can later have a lot of stale credentials which can then be maybe security and/or usability issue. You also might not know what you are affecting so we need separate UI to show you what connections use it so this already starts to look like good filtering on list and mass editing.

@VShawn
Copy link
Member

VShawn commented Feb 24, 2021

这是个很棒的想法,之前也有人提及了此需求,我们也一直在考虑,但却一直没能决定往哪个方向去做。在我看来,分开存储账号和连接信息确实有利于大批量的服务器管理,但同时也会带来软件操作体验的恶化:用户添加一个服务器时不得不先去一个界面新增账号,再去另一个界面添加IP、端口信息。这对于那些“个人”用户来说(比如说我自己)会使新增服务器的操作步骤翻倍,由于这个软件定位首先是 “Personal”, 所以我认为得首先照顾到少量服务器添加/修改的便利性。

目前我的想法是:

  • 思路A:提供批量修改功能,不提供账号密码单独配置。
  • 思路B:提供账号密码单独配置,但同时也要支持独立账号密码。

目前的开发是按照思路A展开的。


It's a great idea, we have been considering it for long, but not beed decided how to support this yet. IMO, the separate storage of account and connection information is indeed conducive to large-scale server management, but at the same time it will also bring the deterioration of the software experience: when users add a server, they have to go to one page to add an account, and then to another page to add IP/port information. For those "personal" users (for example, myself), the operation steps of adding a new server will be doubled. Since this software is mainly pointing on "Personal" use, I think the convenience of adding a small number of servers must be taken care of first..

My current thoughts:

  • Idea A: Provide batch modification function, do not provide separate account and password configuration.
  • Idea B: Provide separate account and password configuration, but also support independent account password.

The current development following by idea A.


目前你可以通过以下步骤进行账号密码的批量修改

At present, you can edit account/passwords by following steps

  1. Firts you can create a connection copy var duplicate

image

  1. You can change multiple connections credentials via Edit selected

image

@VShawn
Copy link
Member

VShawn commented Feb 24, 2021

About Idea B

This idea needs a lot of code change and database change, and brings issues like @majkinetor mentioned above.

One problem with credential list is that it can later have a lot of stale credentials which can then be maybe security and/or usability issue.

I don't like idea B, just for sharing the thought.

UI

UI might look like:

image

  • individual

    when user add connection with an individual credential, he select the individual tab, and the form will be same with the current version.

  • unify
    When user choose unify tab, he can select a credential from sotrage.

Credential

  • auto add
    credential would be able auto save as unify credential when a individual credential connection was saved.

  • auto delete
    when all connections refer to the unify credential were deleted, then the unify credential will be auto deleted.

  • add/edit in setting page.
    need offering a page to manage unify credential

@majkinetor
Copy link
Member

All this can be done without changing one bit of UI or habit. I hurry now but will get back to this soon.

@d0pang
Copy link
Author

d0pang commented Mar 2, 2021

Thank you for your reply. I think both solutions are good and can solve my problems.

@majkinetor majkinetor added this to the Limbo milestone Mar 30, 2021
@VShawn
Copy link
Member

VShawn commented May 20, 2021

@d0pang now we will offer a more powerful bulk editor, see #83

@VShawn VShawn closed this as completed May 20, 2021
@VShawn VShawn modified the milestones: Limbo, NEXT May 31, 2021
@VShawn VShawn modified the milestones: NEXT, 0.5.11 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-supportive Involves supportive infrastructure or tools meta-feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants