Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk editing all attributes of selected connections #83

Closed
majkinetor opened this issue Feb 18, 2021 · 18 comments · Fixed by #124
Closed

Bulk editing all attributes of selected connections #83

majkinetor opened this issue Feb 18, 2021 · 18 comments · Fixed by #124
Assignees
Labels
area-launcher Launcher window (ALT+M) area-list Main window (connection list) general-supportive Involves supportive infrastructure or tools meta-enhancement Enhacement of existing feature
Milestone

Comments

@majkinetor
Copy link
Member

majkinetor commented Feb 18, 2021

Idea in nutshell is:

  1. Add multiselect options and some more advanced filtering
  2. Allow using group actions on selection: Еdit all, Delete all, Connect all (edit explained further)
  3. Show the same edit window as we have it now with following changes:
    1. In multi edit mode warning is shown with number of connections it is applying to
    2. When all connections have the same value it is shown, if not, some special value is shown such as <multiple values> or <unchanged>
    3. There is again warning on save , just to be sure you saw it.
  4. "Server management" should be removed along with special multi edit items in the footer (edit selected, back etc.)
  5. "Edit selected property" should be removed

One decision should be made: if group edit is allowed with multiple protocols or not. I don't think its much of a hassle to implement any of it, but single protocol may be a bit easier.

Some benefits of this approach are:

  1. Group and single edit are basically the same, so no learning or surprises, its intuitive
  2. There are no new interfaces to learn (those removed)
  3. Its maintainable - changing connection edit window automatically changes group edit unlike current option.
Screen mockups

view

view_selected

group_edit

view_cards

---

From discussion at #34

@majkinetor majkinetor added meta-enhancement Enhacement of existing feature general-supportive Involves supportive infrastructure or tools area-launcher Launcher window (ALT+M) area-list Main window (connection list) labels Feb 18, 2021
@majkinetor majkinetor added this to the Limbo milestone Feb 18, 2021
@majkinetor majkinetor assigned VShawn and majkinetor and unassigned VShawn Feb 18, 2021
@majkinetor
Copy link
Member Author

@VShawn , check out description for how I thought this could work.

@majkinetor majkinetor changed the title Managing multiple connections as one Group operations on connections Apr 6, 2021
@majkinetor majkinetor changed the title Group operations on connections Bulk edit connection atttributes Apr 6, 2021
@majkinetor majkinetor changed the title Bulk edit connection atttributes Bulk edit attributes of selected connections Apr 6, 2021
@majkinetor majkinetor changed the title Bulk edit attributes of selected connections Bulk editing all attributes of selected connections Apr 6, 2021
@VShawn
Copy link
Member

VShawn commented Apr 8, 2021

For reference, this is the launcher multi-choice scheme I designed last year for clipboard manager demo by key.

1

just... unfortunately, I don’t have time for PRM recently.

VShawn added a commit that referenced this issue May 10, 2021
@VShawn VShawn modified the milestones: Limbo, NEXT May 10, 2021
@VShawn
Copy link
Member

VShawn commented May 10, 2021

WIP

VShawn added a commit that referenced this issue May 10, 2021
@VShawn
Copy link
Member

VShawn commented May 10, 2021

Complete most of the UI changes on list page

image

@majkinetor
Copy link
Member Author

Nice, looking forward to test that.

Keep in mind that both UI's (panes vs list) should in principle have the same options.

@VShawn
Copy link
Member

VShawn commented May 11, 2021

image

a little bit of progress by huge code re-factoring

VShawn added a commit that referenced this issue May 15, 2021
VShawn added a commit that referenced this issue May 15, 2021
@VShawn
Copy link
Member

VShawn commented May 15, 2021

Done most of the work, The radio button needs to be replaced with combobox in the next step

1

@majkinetor try it
PRemoteM 0.5.10.3-beta3.zip

@majkinetor
Copy link
Member Author

Works great, didn't find any issues.

@majkinetor
Copy link
Member Author

majkinetor commented May 15, 2021

About missing things:

  1. Number of selected items
    1. In the list, somewhere around footer buttons
    2. In config editor as a header or footer so you know you are not modifying single one
  2. Improved search so bulk editing group is easier to form (for example single protocol, server etc.).

@majkinetor
Copy link
Member Author

majkinetor commented May 15, 2021

Cancel button doesn't work

@VShawn
Copy link
Member

VShawn commented May 15, 2021

which cancel button?

image
↑ I‘ve tested this button several times

@majkinetor
Copy link
Member Author

Cancel that shows on the list when you select multiple items

@VShawn
Copy link
Member

VShawn commented May 15, 2021

Cancel that shows on the list when you select multiple items

Yes I forgot that button. 😆

VShawn added a commit that referenced this issue May 17, 2021
1. title for bulk editor.
2. search by group name.
3. count of selected
@VShawn
Copy link
Member

VShawn commented May 17, 2021

I think we've all done this

image

image

Release.zip

@majkinetor
Copy link
Member Author

majkinetor commented May 17, 2021

Cant see that Select 2 items although I see you are editing in bulk. I would make it more visually distinct tho, I would never notice it if I didn't see screenshot. BTW, make it Number of selected items: <N> as that english is wrong and suffers from 1/many grammar problem.


With this major feature done, I would suggest doing #107 next - the bulk connect is awesome but it has 1 big problem - you can't save arbitrary connection lists for bulk connection since connection can have only one group, and you also probably want to group connection based on something else then bulk connecting.

Example: I have 2 database servers on a project along with N other connections. Group name is the name of the project, but I want to connect to db servers only, not anything else. Currently I have to always select db connections then bulk connect. With tags, I could create arbitrary connection lists and bulk connect to them with appropriate UI in single step.

@VShawn
Copy link
Member

VShawn commented May 18, 2021

Number of selected items:

got it

#107 next

sure I came here from #107, but I‘m still hesitating whether to add a tag system.

@VShawn
Copy link
Member

VShawn commented May 18, 2021

image

this should be conspicuous enough

@VShawn VShawn mentioned this issue May 19, 2021
Merged
VShawn added a commit that referenced this issue May 19, 2021
VShawn added a commit that referenced this issue May 20, 2021
@VShawn
Copy link
Member

VShawn commented May 20, 2021

0.5.10.3 beta.zip

@VShawn VShawn modified the milestones: NEXT, 0.5.11 Jul 9, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
1. title for bulk editor.
2. search by group name.
3. count of selected
VShawn added a commit that referenced this issue Dec 23, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-launcher Launcher window (ALT+M) area-list Main window (connection list) general-supportive Involves supportive infrastructure or tools meta-enhancement Enhacement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants