Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RDP): add audio quality mode support #551

Merged
merged 3 commits into from Nov 5, 2023
Merged

feat(RDP): add audio quality mode support #551

merged 3 commits into from Nov 5, 2023

Conversation

sparrowhe
Copy link
Contributor

@sparrowhe sparrowhe commented Nov 5, 2023

@sparrowhe sparrowhe changed the title feat(RDP): add quality mode support feat(RDP): add audio quality mode support Nov 5, 2023
@VShawn VShawn self-requested a review November 5, 2023 02:03
@VShawn VShawn self-assigned this Nov 5, 2023
@VShawn VShawn added meta-enhancement Enhacement of existing feature area-ct-rdp Connection type: RDP labels Nov 5, 2023
@VShawn VShawn added this to the NEXT milestone Nov 5, 2023
Copy link
Member

@VShawn VShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to hide the audio quality options when AudioRedirectionMode is not RedirectToLocal

Ui/View/Editor/Forms/RdpFormView.xaml Outdated Show resolved Hide resolved
@VShawn
Copy link
Member

VShawn commented Nov 5, 2023

感动,这一套逻辑修改、界面修改、国际化词组翻译的流程终于有人跑通并且提交功能性PR了 🌹 ❤️

review 后发现一个小问题,音频质量选项只有在用户选择了将音频重定向到本地后才是有意义的,因此当没有选择音频重定向到本地时,界面上应当隐藏音频质量选项。

你看准备你改还是我直接帮你改了?

@sparrowhe
Copy link
Contributor Author

感谢作者辛勤付出和认可,这也是我第一次参与 C# 开源项目做出贡献,上面提到的小问题我先尝试改一下。

@sparrowhe sparrowhe requested a review from VShawn November 5, 2023 02:53
@VShawn VShawn merged commit 2bce49f into 1Remote:main Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ct-rdp Connection type: RDP meta-enhancement Enhacement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants