feat(prefetch): add pg #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zztaki <zztaki@outlook.com>
1a1a11a
reviewed
Feb 21, 2024
| if (prefetch_list) { | ||
| GList *node = prefetch_list; | ||
| request_t *new_req = my_malloc(request_t); | ||
| memcpy(new_req, req, sizeof(request_t)); |
There was a problem hiding this comment.
it might be better to use copy_request if we plan to add some tracking when a request is copied
|
I would not worry about the 32-bit issue. It would be good to add some documentation on how to use the prefetching algorithm (maybe a few lines in the |
|
If you want to add the documentation after finishing everything, it is fine as well. :) |
Yes, I am glad to add the documentations! :) Do you mind if I create a few PRs later to add documents related to admission and prefetching? Probably within ten hours. 😄 |
|
Sounds good! I will merge this PR for now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reconstructed the PG prefetching algorithm, and it is worth mentioning that I use direct_hash for all hashtables, which means that I used
GINT_TO_POINTERandGPOINTER_TO_INTto convertobj_idorobj_sizeas the key or the value. Compared tog_int64_hash, this can reduce the overhead of allocation, dereference, and memory release.Maybe there is a problem on a 32 bit machine, where
longandvoid*maybe are both 4 bytes. :(