Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chiunam
Love your work a lot, until I found this design may cause some weird bugs.
What Did I change?
no
dismissViewControllerAnimated:completion:
call in-dismiss
when-assetsPickerControllerDidCancel
is implementedWhy?
imagePickerControllerDidCancel:
, UIImagePickerController just does't do anything. So, I hope CTAssetsPickerController could stay consistent.I just deleted the
dismissViewControllerAnimated:completion:
at first, then I think if user doesn't implement-assetsPickerControllerDidCancel
, it should stay what it behaves as you designed, so I put it in anelse
.Hope you agree with my thoughts. :D