Fixed issue on iPad in portrait mode / minor fix of German translation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugort
changed the title
1and2papa
added a commit
that referenced
this pull request
Aug 20, 2015
Fixed issue on iPad in portrait mode / minor fix of German translation
|
@ugort Thank you. UISplitViewController really drives me nuts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
commit 0d929ac fixes an issue on iPad. When using in portrait mode only a white screen is shown. This is simply because UISplitViewController will not show the primary view controller when in portrait mode on iPad. I changed the preferredDisplayMode in order to show primary and secondary view controllers. This should work for all use cases of CTAssetsPickerController.
It will also fix issue #134
The second commit is a minor improvement for the german translation.
Best regards
Urs