Диагностика: Запрещенное имя методанных #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixel2007
reviewed
Oct 5, 2021
...va/com/github/_1c_syntax/bsl/languageserver/diagnostics/ForbiddenMetadataNameDiagnostic.java
Outdated
Show resolved
Hide resolved
nixel2007
reviewed
Oct 5, 2021
| private void checkName(String name, MDOReference mdoReference) { | ||
| if (FORBIDDEN_NAMES_PATTERN.matcher(name).matches()) { | ||
| String mdoRef; | ||
| if (serverConfiguration.getLanguage() == Language.RU) { |
There was a problem hiding this comment.
увы, но так... надо что-то думать с mdoref для печати
nixel2007
reviewed
Oct 5, 2021
|
|
||
| @Override | ||
| protected void check() { | ||
| Ranges.getFirstSignificantTokenRange(documentContext.getTokens()) |
There was a problem hiding this comment.
а такое срабатывание погасится через diagnosticIgnorance?
There was a problem hiding this comment.
нет, так же как и остальные по подобному принципу, например общие модули
There was a problem hiding this comment.
надо бы потом отдельно это зачинить как-нибудь
nixel2007
approved these changes
Oct 5, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Реализована диагностика, обнаруживающая метаданные с именами, использование которых в запросе не рекомендуется стандартом 1С.
Замечания вешаются на первый рендж модуля по приоритету
Связанные задачи
Closes: #1130
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно