Checks connection every 5 seconds #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorin-chime
reviewed
Nov 11, 2022
functions/replace-route/app.py
Outdated
| Returns False if the connection fails and the route is replaced. | ||
|
|
||
| """ | ||
| try: |
There was a problem hiding this comment.
DRY: looks like an opportunity to have a configurable array of hosts to check and just iterating over that
DEFAULT_CONNECTIVITY_HOSTS = ['https://www.example.com', 'https://www.google.com']
for host in DEFAULT_CONNECTIVITY_HOSTS:
<check code here>
madhurimachime
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the connectivity test to check every 5 seconds for about a minute before exiting. This reduces the maximum time a connection loss could occur (previously it could be as long as about a minute).