-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise build system to use gulp #2
Comments
Can I work on this? |
@kme211 Go for it! |
@1egoman I have been working on adding Gulp in branch feat-2 in my fork. Can you take a look and let me know if I'm on the right track? https://github.com/kme211/funnies/tree/feat-2 I added a default task which doesn't minify as sort of a development build and then a production task which minfies and and sets the NODE_ENV to production so that Uglifyify will remove the development portion of the React lib. |
Nice job @kme211! A few notes:
Thanks for all your hard work! |
@kme211 Also, if you open a pull request with your changes Travis CI will start building you changes, which may be helpful to confirm that everything you've written so far works in CI. |
Thanks for taking the time to give me feedback! I think the only thing left is adding a watch task which I'm fine with someone else tackling it since they will probably be able to get to it before I can. Oh, also I added the babel presets to the dev dependencies but then I realized they were already in the regular dependencies after I submitted my PR. |
(Note to self: issue for a watch task #45) |
This package's build scripts need some work. I set up the build very fast and I think it's time to move to something like
gulp
to build this with instead of the mismatch of scripts that are in thepackage.json
.What this task entails:
Gulpfile
:babel
to transpile react/es2015browserify
uglifyjs
"main"
in thepackage.json
to point to the compiled output.The text was updated successfully, but these errors were encountered: