[SC-989][SC-990] Solidity 0.8.23, OZ 5.0.0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zZoMROT
commented
Nov 14, 2023
•
zZoMROT
commented
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 99 99
Branches 21 21
=========================================
Hits 99 99 ☔ View full report in Codecov by Sentry. |
|
Please add gas reports comparison |
ZumZoom
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Reuse .solcover.js from here https://github.com/1inch/solidity-utils/blob/master/.solcover.js
There was a problem hiding this comment.
With config from solidity-utils we have Stack Too Deep error
YulException: Cannot swap Variable expr with Slot TMP[eq, 0]: too deep in the stack by 2 slots in [ _6 expr var_account expr expr_2 _11 _10 _9 _8 _7 expr_2186_mpos _5 _4 _3 RET _2 _13 var_i var_account TMP[eq, 0] ]
memoryguard was present.
Done. You can find it in first comment of this PR |
ZumZoom
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.