New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shift+right click opens context menu in Firefox #161
Comments
To https://github.com/1j01/jspaint/tree/8a0f27172d29802fb97fd9e031c872166d8a89cc jspaint now uses os-gui, so the theme is applied from the desktop into jspaint! Note: setPointerCapture for iframe integration has been reverted in 1j01/jspaint@ecb7459 See issue: 1j01/jspaint#161
Since some firefox updates is impossible to absolutely disable the context menu because if you disable it firefox core automatically sets the context menu shortcut to Shift + Right Click, the user itself can disable it in the firefox settings going to: Tools > Options > Content > Advanced and the activate 'Enable Javascript' and 'Disable or replace context menus' settings. Due to this I think this shouldn't be catalogued as 'bug'. |
@AlexHRodrii How do I get to "Tools > Options > Content > Advanced"? What version of Firefox does this apply to? |
Disabling I poked around and found some discussion of this on the Firefox bug tracker: 1, 2, 3. There doesn't seem to be many people pointing out use cases, so I might join the discussion. I'm writing my notes here in case I come back to this later: Two use cases I see, aside from user interfaces that directly use Shift+right click as a gesture, are:
|
Right mouse button is used to access the secondary (background) color, and shift is used to make equal width/height shapes.
Shift+right click is clearly an escape hatch for users of Firefox, to access the context menu on sites that block it willy-nilly. I'd like to preserve this ability where it doesn't conflict.
Plan: listen for and prevent
contextmenu
globally while canvas-related gesture is active.May need a timeout after
pointerup
ifcontextmenu
comes afterpointerup
.This should also fix dragging with right click over a window like About Paint showing a context menu. I'm not sure about the Help window, which uses an iframe to display the content.
This should also let me un-revert
setPointerCapture
for 98.js.org integration.The text was updated successfully, but these errors were encountered: