Skip to content

Commit

Permalink
Use HTTPS for all links
Browse files Browse the repository at this point in the history
- Fix CORS mixed content issue michaelbromley#9
- Prefer HTTPS for all links, all of which are tested to work
  • Loading branch information
1j01 committed Jul 14, 2018
1 parent 75c17a0 commit a4c700c
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ This is an experiment in using the web audio API together with canvas to make so

Since this is my first foray into the world of both canvas and web audio, I have slowly iterated over a number of ideas and trials which are all in the `/tests` folder.

The visual style was inspired by the artwork of the album ["The Resistance"] (http://en.wikipedia.org/wiki/File:Theresistance.jpg) by Muse.
The visual style was inspired by the artwork of the album ["The Resistance"] (https://en.wikipedia.org/wiki/File:Theresistance.jpg) by Muse.

Thanks to [Soundcloud] (https://soundcloud.com) for providing a great open API!

# Demo

[Here's a working demo] (http://www.michaelbromley.co.uk/experiments/soundcloud-vis/#muse/undisclosed-desires). Enjoy and share!
[Here's a working demo] (https://www.michaelbromley.co.uk/experiments/soundcloud-vis/#muse/undisclosed-desires). Enjoy and share!

**Update May 2015** - As of latest versions of Chrome (42+) and recent versions of Firefox, changes in the way cross-origin audio is handled mean this demo may not work. It's a well-known issue for everyone who's used the SoundCloud API for JavaScript visualizations (there are a lot of us).

Expand Down
6 changes: 3 additions & 3 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</head>
<body>
<div id="info">
Soundcloud visualizer: a canvas and webaudio API experiment by <a href="http://www.michaelbromley.co.uk">Michael Bromley</a>.<br>
Soundcloud visualizer: a canvas and webaudio API experiment by <a href="https://www.michaelbromley.co.uk">Michael Bromley</a>.<br>
For more information, visit the project's <a href="https://github.com/michaelbromley/soundcloud-visualizer">Github page</a><br><br>
<b>Instructions</b><br>
Paste the URL of a Soundcloud track or playlist into form and press enter.<br><br>
Expand Down Expand Up @@ -42,10 +42,10 @@
<footer>
<a href="#" id="credit"> <i class="icon-info"></i> About</a>
<span id="github"><a href="https://github.com/michaelbromley/soundcloud-visualizer"><i class="icon-github"></i> Source on Github</a></span>
<span id="scLogo"><a href="http://soundcloud.com/"><img src="assets/powered_by_white.png"></a></span>
<span id="scLogo"><a href="https://soundcloud.com/"><img src="assets/powered_by_white.png"></a></span>
</footer>

<script src="http://connect.soundcloud.com/sdk.js"></script>
<script src="https://connect.soundcloud.com/sdk.js"></script>
<script src="js/app.js"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ var Visualizer = function() {
*/
var SoundcloudLoader = function(player,uiUpdater) {
var self = this;
var client_id = "YOUR_SOUNDCLOUD_CLIENT_ID"; // to get an ID go to http://developers.soundcloud.com/
var client_id = "YOUR_SOUNDCLOUD_CLIENT_ID"; // to get an ID go to https://developers.soundcloud.com/
this.sound = {};
this.streamUrl = "";
this.errorMessage = "";
Expand Down
2 changes: 1 addition & 1 deletion tests/test11_embedded_audio.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html>
<head>
<title></title>
<script src="http://connect.soundcloud.com/sdk.js"></script>
<script src="https://connect.soundcloud.com/sdk.js"></script>
<script>
function loadAndPlay(track_url) {

Expand Down
2 changes: 1 addition & 1 deletion tests/test12_soundcloud_visualizer.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html>
<head>
<title></title>
<script src="http://connect.soundcloud.com/sdk.js"></script>
<script src="https://connect.soundcloud.com/sdk.js"></script>
<script>

/**
Expand Down

0 comments on commit a4c700c

Please sign in to comment.