Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating usage of mybinder in docs. #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HarshithaPrabhuswamy
Copy link

@HarshithaPrabhuswamy HarshithaPrabhuswamy commented Feb 6, 2024

Update to make the Jupyter Notebooks in the docs interactive.

@HarshithaPrabhuswamy HarshithaPrabhuswamy marked this pull request as draft February 6, 2024 10:50
@HarshithaPrabhuswamy HarshithaPrabhuswamy marked this pull request as ready for review February 6, 2024 10:50
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9fde69) 94.11% compared to head (1cadc40) 94.17%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   94.11%   94.17%   +0.06%     
==========================================
  Files         122      122              
  Lines        4840     4843       +3     
==========================================
+ Hits         4555     4561       +6     
+ Misses        285      282       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1kastner
Copy link
Owner

Thank you @HarshithaPrabhuswamy for this nice addition that tackles #91.

Please drop the changes in Readme.md as we do not need to explain nbsphinx here.

Have you tried compiling the docs locally and did everything work out there? Please see https://github.com/1kastner/conflowgen/blob/main/Contributing.md#generate-the-documentation for hints on how to do that in case you haven't done so yet.

Please make sure that the links in the compiled documentation actually point at the documentation of ConFlowGen so that our Jupyter notebooks will turn interactive. Thanks for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants