-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port greenio to Trollius #5
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ca896e1
port greenio to Python 2 and Trollius
haypoenovance 122746a
port tests to Python 2 and Trollius
haypoenovance 8acd6ef
Fix test_tasks.py on Python 3.3
haypoenovance d466c25
fix yield_from() on Python 2 for exc.__traceback__
haypoenovance 3f1186e
get TestCase from Trollius to get assertRaisesRegex
haypoenovance 11432c9
Trollius coroutines must use "yield From()"
haypoenovance b60e8ea
trollius: modify task_factory to build GreenTask
haypoenovance cacb3c9
Fix test_task_yield_from_invalid() on Trollius
haypoenovance e45e5ac
replace task_factory with create_task() method
vstinner 2ffb0d1
Fix test_task_yield_from_invalid() with asyncio
vstinner cd5af01
prefer asyncio over trollius
haypoenovance c8457fe
Test features instead of testing the Python version
haypoenovance e02765a
Fix greenio.task()
haypoenovance 23ca85c
fix tests
haypoenovance File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the need to do this, but it still feels very wrong :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, can you elaborate? What's "wrong"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the need: "yield from" syntax raises a SyntaxError on Python 2, you just cannot import the module.
It may be possible to use different files, but I prefer to keep all code in a single code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that, that's the part that feels wrong, big
#ifdef trollius
around blocks of code.But I guess this is how it goes....