Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support fot PHP < 8.1 #297

Merged

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Mar 7, 2024

drop support for symfony < 5.4
bump min dev versions
remove BC Layer for < symfony 5.3

https://www.php.net/supported-versions.php
https://packagist.org/packages/oneup/flysystem-bundle/php-stats#4

drop support for symfony < 5.4
bump min dev versions
@Chris53897
Copy link
Contributor Author

I would not consider this as a BC break. Bump min versions in minor versions is allowed in semver.
I guess this change should be save.
https://github.com/1up-lab/OneupFlysystemBundle/pull/297/files#diff-ebe00144d6cecb5ca8a2860883e01147f42bbed2b12a3a7f44915908a4829faaR14

I resolved the conflict.
Please let me know if i should change something.

@bytehead bytehead removed the BC break label Mar 14, 2024
@bytehead
Copy link
Member

Thank you, I'll look into it! 🙏

@bytehead bytehead changed the title feat: drop support fot PHP < 8.1 Drop support fot PHP < 8.1 Mar 14, 2024
@bytehead bytehead merged commit 76949b0 into 1up-lab:main Mar 14, 2024
10 checks passed
@Chris53897 Chris53897 deleted the feature/drop-support-for-symfony-php branch March 14, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants