-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for defining filesystem plugins in config #42
Conversation
It makes sense to define the list plugins we want to use for the filesystem directly in the config. This way we don't have to mess with the service's definition.
I will add this to the docs if the PR is accepted :) |
@sheeep any thought on this? |
This is a great idea! Should we get rid of the configuration way of defining plugins ( We should probably add the plugins provided by Flysystem itself as services. |
If you are not worried about Backward Compatibility I say we provide only 1 single method to make things simple |
As we're bumping the major version anyways, I'd suggest to stick to a single method. |
What is the next step? Do you want something else to be added/removed before we go ahead with this PR? :) |
I removed the plugin compiler pass in favour of the new service-way of attaching plugins to your filesystem. Also checked, that the test suite runs without errors and documented it clearly.
Take a look at your repository. I created a pull request which removes the old method of attaching plugins and defines the ones that are already provided by the flysystem library. Another thing to discuss. Removing the I've thought about something like: oneup_flysystem:
plugins:
- global_plugin
filesystems:
my_filesystem:
plugins:
- local_plugin Whereas What do you think? |
Definitely makes sense to me :) |
Very well. I'll create another pull request to your repository asap. :) |
Removed the old method to attach plugins.
Add support for defining filesystem plugins in config
It makes sense to define the list plugins we want to use for the
filesystem directly in the config. This way we don't have to mess
with the service's definition.