Symfony 4 support #295
Symfony 4 support #295
Conversation
|
Thanks for contributing! I'll place some comments where needed :) |
Tests/App/AppKernel.php
Outdated
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| namespace Oneup\UploaderBundle\Tests; | |||
There was a problem hiding this comment.
This should be namespace Oneup\UploaderBundle\Tests\App;
phpunit.xml.dist
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <phpunit bootstrap="./Tests/bootstrap.php" colors="true"> | |||
| <php> | |||
| <server name="KERNEL_DIR" value="Tests/App" /> | |||
There was a problem hiding this comment.
KERNEL_DIR must not be removed, still used for Symfony 2.x and 3.x tests.
| "twistor/flysystem-stream-wrapper": "^1.0" | ||
| }, | ||
|
|
||
| "suggest": { | ||
| "knplabs/knp-gaufrette-bundle": "0.1.*", | ||
| "oneup/flysystem-bundle": "^1.2", | ||
| "oneup/flysystem-bundle": "^3.0", |
There was a problem hiding this comment.
Be aware: to keep it compatible with Symfony 2, 3, and 4 as well as PHP 5.6 and 7.x the constraint should be ^1.2|^2.0|^3.0 :)
There was a problem hiding this comment.
Sorry, didnt' see it's only a suggest. Then you're right!
composer.json
Outdated
| @@ -27,7 +27,7 @@ | |||
| "require-dev": { | |||
| "amazonwebservices/aws-sdk-for-php": "1.5.*", | |||
| "knplabs/gaufrette": "0.2.*@dev", | |||
| "oneup/flysystem-bundle": "^3.0", | |||
| "oneup/flysystem-bundle": "^1.2|^3.0", | |||
There was a problem hiding this comment.
Could also be compatible with version 2.x of the oneup/flysystem-bundle:
"oneup/flysystem-bundle": "^1.2|^2.0|^3.0",
composer.json
Outdated
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| "require": { | |||
| "php":">=5.4", | |||
| "symfony/framework-bundle": "^2.4|^3.0|^4.0", | |||
| "symfony/framework-bundle": "4.0.*", | |||
There was a problem hiding this comment.
We should still be compatible with Symfony 2.x and 3.x
^2.4|^3.0|^4.0 will be the right constraint.
|
The tests fail probably due to symfony/symfony#24524. |
|
In symfony 4 all services will be private. We need to make OneupUploaderBundle services public by default or refractor services to remove container->get calls, or make public services used in tests. |
|
I'll close this in favour of #300. Thanks for the PR! |
#SymfonyConHackday2017