[WIP] Release 1.0 #57

sheeep · 2013-10-08T19:00:44Z

This is a Work in Progress pull request for collecting all changes related to the 1.0 release candidate. The following things should either be discussed and rejected or implemented:

Remove fineuploader as default value for the frontend configuration key.
Make request passing in ValidationEvent mandatory. (Pass the request to validation event #23)
Fix Scrutinizer errors and notices.
Make the temporary chunk directory configurable, so one could use Gaufrette. This is important if you want to use chunked uploads behind a load balancer. (Any ideas for scaling? #53)
It should be configurable to store uploaded files asynchronously. This could be a performance improvement if your application deals with big files. (Asynchronous backend file-uploading #58)
Add a Next step section to the frontend documentation files.
Remove extension validators. They fit no needs and are a potential security hole. (Use two upload zones #59)

If you like to discuss a specific topic, please open an issue (if not yet done) and reference to this pull request.
I'd be very happy if you decide to help me with this release. Please send pull requests to the release-1.0 branch. If merged, they will appear here. Thanks in advance. :)

This was a legacy decision which will be changed in 1.0.0. The first version of this Bundle only supported Fineuploader which would have been a BC break if 'fineuploader' was not the default value.

…fronend config.

…undle into release-1.0

…alancers. This is WIP.

Documentation fixes.

Raised requirement of symfony/framework-bundle to >=2.2.

Strangly on my machine the function tempnam returns something different than expected. tempnam('/foo', 'bar'); returns a file located in /private/foo. The way this test works does not allow this behaviour. This is why we test this condition and mark the test skipped.

This way it is not important to remember appending a / to the end of the stream_wrapper string.

Documentation / Test / Little Improvement

This reverts commit 5e789d8.

…to mitom-release-1.0 Conflicts: EventListener/AllowedExtensionValidationListener.php EventListener/DisallowedExtensionValidationListener.php

mitom · 2013-10-14T19:22:25Z

@sheeep you broke scrutinizer! :D

sheeep · 2013-10-14T19:24:20Z

@sheeep you broke scrutinizer! :D

Damn! Good thing I've not checked the Fix Scrutinizer errors and notices. yet. :)

…to mitom-release-1.0 Conflicts: Controller/AbstractChunkedController.php

Fix configuration for storage service creation

Do not test against: too_many_methods too_many_fields coupling_between_objects As this bundle provides a base Controller that is dependant on many coupled objects/interfaces, the coupling does not really make sense to test.

Release 1.0

sheeep · 2013-10-23T14:04:46Z

Thanks to everyone who helped making this release possible. Especially @mitom and @Paulmolin
As a sign of my appreciation, here is a cat wearing a hat.

Paulmolin · 2013-10-24T08:09:19Z

Thanks for the cat, and thanks for your great bundle! You rock! 😉

sheeep and others added 30 commits October 8, 2013 20:31

Removed default value 'fineuploader' for frontend key in Configuration.

8a2fc86

This was a legacy decision which will be changed in 1.0.0. The first version of this Bundle only supported Fineuploader which would have been a BC break if 'fineuploader' was not the default value.

Removed a notice which was stating that there is a default value for …

d64ade8

…fronend config.

Made request passing in ValidationEvent mandatory.

73e39c5

Fixed "unused code" labels in Scrutinizer report.

3cee34e

Added Next Steps section to frontend documentations.

4b7e0aa

gaufrette chunk storage

ad5577f

separated storages both in definition and configuration

130bef2

moved the metadatasupporter check

f795b14

better file size calculation for gaufrette files

f1f84bc

fix non-chunked uploads and improve extension handling

4769708

fixed messy type hinting for more comprehensible structure

39c94c5

made scrutiziner happier

fc1bd5e

broke configuration up even more fro scrutinizer

bd400e8

had to lower interface requirements for the controllers

85dd84a

fixed existing tests and some mistakes revealed by them

7884373

don't test for sf2.1

c5a87ee

Update configuration_reference.md

db91777

Update chunked_uploads.md

4798b10

Update gaufrette_storage.md

a47326e

Update chunked_uploads.md

7bb3f2a

Update custom_namer.md

160c9a1

orphanage for gaufrette chunk storage

082f119

Merge branch 'release-1.0' of https://github.com/mitom/OneupUploaderB…

948d850

…undle into release-1.0

typo

94d6d30

Update orphanage.md

0223eea

gaufrette orphanage fixes and tests

155aca3

added missing files

71acfbe

fix for php5.3

98f2a90

gaufette chunk storage test

052148a

file tests

529b01c

sheeep and others added 14 commits October 11, 2013 19:19

Fixed some typos in documentation.

e7cb8dc

Added a documentation topic: How to use Chunked Uploads behind Load B…

207d2f1

…alancers. This is WIP.

Merge pull request #1 from sheeep/release-1.0

80ba434

Documentation fixes.

Raised requirement of symfony/framework-bundle to >=2.2.

50d14cc

Merge pull request #2 from sheeep/release-1.0

9a7ce28

Raised requirement of symfony/framework-bundle to >=2.2.

remove file from gaufrette chunk storage after upload

47c9e32

avoid post-chunk upload events to fire with empty files

01e3347

Normalize stream wrapper path.

15a4590

This way it is not important to remember appending a / to the end of the stream_wrapper string.

Extended documentation about chunked uploads and Gaufrette.

988082e

Merge pull request #3 from sheeep/release-1.0

efaa424

Documentation / Test / Little Improvement

made docs a bit nicer with a check

5e789d8

Revert "made docs a bit nicer with a check"

147388f

This reverts commit 5e789d8.

Merge branch 'release-1.0' of github.com:mitom/OneupUploaderBundle in…

d0cdf7a

…to mitom-release-1.0 Conflicts: EventListener/AllowedExtensionValidationListener.php EventListener/DisallowedExtensionValidationListener.php

sheeep and others added 8 commits October 14, 2013 21:31

Test against null to avoid object to boolean conversion.

341c880

fixed event firing check

0095863

Merge branch 'release-1.0' of github.com:mitom/OneupUploaderBundle in…

c9c64c9

…to mitom-release-1.0 Conflicts: Controller/AbstractChunkedController.php

Fix configuration for storage service creation

b17bee4

Merge pull request #63 from Paulmolin/release-1.0

bfc3e81

Fix configuration for storage service creation

Fixes scrutinizer-ci warnings.

996a784

Do not test against: too_many_methods too_many_fields coupling_between_objects As this bundle provides a base Controller that is dependant on many coupled objects/interfaces, the coupling does not really make sense to test.

Use 1.0 version of this bundle.

d265291

Added Upgrade Note about version 1.0.

8e21e81

sheeep pushed a commit that referenced this pull request Oct 23, 2013

Merge pull request #57 from 1up-lab/release-1.0

0a5c5d1

Release 1.0

sheeep merged commit 0a5c5d1 into master Oct 23, 2013

sheeep mentioned this pull request Mar 17, 2014

Create version branches that correspond to Symfony version #97

Closed

bytehead deleted the release-1.0 branch January 4, 2016 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Release 1.0 #57

[WIP] Release 1.0 #57

sheeep commented Oct 8, 2013

mitom commented Oct 14, 2013

sheeep commented Oct 14, 2013

sheeep commented Oct 23, 2013

Paulmolin commented Oct 24, 2013

[WIP] Release 1.0 #57

[WIP] Release 1.0 #57

Conversation

sheeep commented Oct 8, 2013

mitom commented Oct 14, 2013

sheeep commented Oct 14, 2013

sheeep commented Oct 23, 2013

Paulmolin commented Oct 24, 2013