Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-clock entries in logbook #112

Merged
merged 6 commits into from
Nov 22, 2019

Conversation

jamesnvc
Copy link
Contributor

@jamesnvc jamesnvc commented Nov 22, 2019

Address #111 and (hopefully) #108 (edit: and #110)

Currently, this lacks the ability to edit comments/non-clock lines in the logbook, but will preserve them.

@munen
Copy link
Collaborator

munen commented Nov 22, 2019

Big thanks for the quick PR! 🙏

During testing, I found a regression. When there's comments in the :LOGBOOK: drawer, the only action is "clock out", never "clock in". That's because the hasActiveClock logic in Header/index.js only looks for missing end elements whereas now it should probably also look for raw elements.

image

@munen
Copy link
Collaborator

munen commented Nov 22, 2019

@jamesnvc Super job - PR looking sharp as always! 🙏

Gladly pulling it in without changes^^

@munen munen merged commit 518d1df into 200ok-ch:master Nov 22, 2019
@munen
Copy link
Collaborator

munen commented Nov 22, 2019

I updated the changelog with attribution: c9375f8

Great job on potentially closing three issues in one go! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants