Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make header sticky #870

Merged
merged 2 commits into from
Jul 6, 2022
Merged

fix: Make header sticky #870

merged 2 commits into from
Jul 6, 2022

Conversation

munen
Copy link
Collaborator

@munen munen commented Jun 30, 2022

Closes: #865

@munen munen requested a review from tarnung June 30, 2022 17:54
@munen
Copy link
Collaborator Author

munen commented Jul 6, 2022

@tarnung It looks like you're busy. The PR might not include all cases (it took us multiple tries the last time, too), but I think it's better to merge it soon rather than later. You can still review it at a later time.

@branch14
Copy link
Member

branch14 commented Jul 6, 2022

Reviewed and LGTM. 👌

@branch14 branch14 merged commit e801c39 into master Jul 6, 2022
@branch14 branch14 deleted the fix/make-header-sticky branch July 6, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarnung tarnung Awaiting requested review from tarnung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header scrolls off screen
2 participants
@munen @branch14