Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade capacitor 4 and react-scripts 4 #924

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

ieugen
Copy link

@ieugen ieugen commented Jan 4, 2023

IMPORTANT - Remove node_modules/ to redownload deps

  • React scripts upgrade is a preparation for nodejs lts upgrade (version 18 is LTS as of now)
  • We will try react-scripts 5 upgrade later and React upgrade as well
    *Minimum nodejs 12.20 is needed by a capacitor dependency
  • eslint 7 is required by react-scripts 4.x
  • Removed global declaration for process - fix eslint 7 issue
  • Because of the upgrades, some deps PR's will be made obsolete

References

@ieugen ieugen force-pushed the capacitor4 branch 2 times, most recently from e7681d3 to b2cfa54 Compare January 4, 2023 16:05
* yarn add --exact react-scripts@4.0.3
* fixed OrgFile integration test

https://github.com/facebook/create-react-app/blob/main/CHANGELOG-4.x.md
@munen munen changed the base branch from develop to feat/upgrade-capacitor-and-react_scripts January 5, 2023 14:40
@munen munen added this to the native-app milestone Jan 5, 2023
@munen munen changed the base branch from feat/upgrade-capacitor-and-react_scripts to develop January 5, 2023 14:42
@munen
Copy link
Collaborator

munen commented Jan 5, 2023

This looks good to me. It works locally. And as a test, I've deployed it to Staging, already. On first tests on FF/Linux, everything seems to continue to work.

Since packaging organice into a native app is a major effort, this is how I'll structure the existing work for future reviews:

  1. I'll merge this PR to develop. Future PRs regarding mobile app integration can also be done against develop.
  2. Directly afterwards, I'll create a separate PR from develop into a new feature branch against master describing what has happened so far.
  3. This new feature PR will be part of a bigger milestone 'native-app.
  4. These feature PRs are mainly due to the fact that the current develop is not 100% finished and reviewed.

@munen munen merged commit 4791f4a into 200ok-ch:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants