allows overriding the controller names for which the stripe headers a…

[jagui]

allows overriding the controller names for which the stripe headers are sent.

This eases integrating stripe with 3rd party one page checkout modules.

[clotairer]

Thank you for your PR and suggestion.

To be in the same "spirit" of the module, I'd rather a declaration like "public $controllers" or hooks "public $hooks".
But, we are not comfortable with overrides and perhaps exec an hook should be better.

$orderPageNames = ['order', 'order-opc'];
Hook::exec('actionStripeDefineOrderPageNames', &$orderPageNames);

What do you think about it ?

[jagui]

@clotaire202 yeah, I like the idea, please check the new commit. Please note that I'm using (min) php7.0, therefore call time pass by reference is not allowed. Hence I'm merging the result of the hook with the base array.

I'll squash the changes once we reach an agreement.
Thanks, Juan

[jagui]

@clotaire202 After thinking this through I've realized we can the array by reference by means of an intermediate array. I've updated the PR accordingly.

[clotairer]

thank you

[clotairer]

I see two theoretical problems:

• if you have two modules hook the last will override previous values
• if someone want to unset an orderPage previously added, the hook cannot manage this case

        $orderPages = [
            'order',
            'order-opc',
        ];
        Hook::exec('actionStripeDefineOrderPageNames', [ 'orderPages' => &$orderPages ]);

And to call this hook :

    public function hookActionStripeDefineOrderPageNames($params)
    {
        $extraOrderPages = [
            'my-order',
        ];
        $params['orderPages'] = array_merge($params['orderPages'], $extraOrderPages);
    }

[jagui]

I've squashed the changes a single commit.

[clotairer]

Thank you for your contribution. I've just merged your PR in develop branch.