Add user creation flow #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirilknysh
reviewed
Mar 22, 2017
package.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| "express": "^4.14.0", | |||
| "express-session": "^1.15.0", | |||
| "lru-native": "^0.4.0", | |||
| "message-factory": "21-23/message-factory#v2.4.0", | |||
| "message-factory": "21-23/message-factory#v2.5.0", | |||
There was a problem hiding this comment.
In yarn lock file the version is still 2.4.0. Use yarn remove message-factory + yarn add 21-23/message-factory#v2.5.0
src/ws/ws-server.js
Outdated
| function processServerMessage(message) { | ||
| // TODO: move participant validation here | ||
| switch (message.name) { | ||
| case MESSAGE_NAME.participantJoined: | ||
| return participantIdentified(message.participantId, message.sessionId, message.role); | ||
| case MESSAGE_NAME.solutionEvaluated: | ||
| return solutionEvaluated(message); | ||
| case MESSAGE_NAME.createParticipant: | ||
| return createNewParticipant(message); |
There was a problem hiding this comment.
IMHO return createNewParticipant(message.userData); is better - createNewParticipant doesn't need the whole message
src/ws/ws-server.js
Outdated
| @@ -217,13 +219,25 @@ function processNewConnection(ws) { | |||
| }); | |||
| } | |||
|
|
|||
| function createNewParticipant(message) { | |||
| return UserService.create(message.userData) | |||
| .then((user) => { | |||
There was a problem hiding this comment.
As agreed - it user service operation will never throw but the error fact is 'null' in then callback. Please add a check for user
src/ws/ws-server.js
Outdated
| @@ -9,6 +9,8 @@ const config = require('../../config'); | |||
| const Server = WebSocketClient.Server; | |||
| const phoenix = createPhoenix(WebSocketClient, { uri: config.get('ARNAUX_URL'), timeout: 500 }); | |||
|
|
|||
| const UserService = require('../services/user-service'); | |||
There was a problem hiding this comment.
I strongly believe that ws-server will become a separate service in (near) future. So please pass the dependency into createWsServer (similar to parseCookie and loadProfiles)
|
Conflicts |
|
@humanamburu done |
humanamburu
approved these changes
Mar 26, 2017
DaQuirm
approved these changes
Mar 26, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.