-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightcone Checkpointing and Other Fixes #299
Open
steven-murray
wants to merge
15
commits into
master
Choose a base branch
from
fail-on-Tk-inf
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few main things:
hook
to do this (also in this PR) but even with that, there was no way of "going back" and getting the interpolated lightcone slices. So I re-arranged a bit of therun_lightcone
code so that it can identify a lightcone save file, and if it exists, it will read partial information from there.initial_conditions()
and it finds a cached box, now we DON'T read in all the data, just the basic metadata. Since it's being read from a file, access to any of the computed arrays will lazily load the data anyway, so this provides a reasonable speedup when the boxes are big -- some of the arrays never need to be loaded at all.cache_tools.get_boxes_at_redshift
function which makes it easier to load all the cached boxes matching some given set of input parameters and redshift specification.log10_Mturnover_ave
etc. from LightCone as they should be computed using theglobal_quantities
entry torun_lightcone
.