Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Path become out of sync with certain folders being drag/dropped #304

Open
nickdatum opened this issue Apr 26, 2016 · 5 comments
Open

Comments

@nickdatum
Copy link
Contributor

nickdatum commented Apr 26, 2016

If you take a look at this JS Fiddle and drag the folder attached (extract from the zip first) to the black box, and make sure you check the Javascript console, you will see the relative paths being reported incorrectly:

https://jsfiddle.net/ad3q077k/4/

Folder drag/drop support is in Chrome, so please test using this browser.

Assets.zip

I believe the issue occurs in resumable.js around line 285, as this is an asynchronous callback and the JS continues execution and over-writes the path variable later down the code (but the asynchronous callback doesn't appear to execute in time, before the path changes.

nickdatum added a commit to nickdatum/resumable.js that referenced this issue May 10, 2016
Fixed relative paths submitting incorrectly ref 23#304
@nickdatum
Copy link
Contributor Author

nickdatum commented May 10, 2016

I believe I've been able to fix this now...I've created a pull request

@steffentchr
Copy link
Member

Did you update the jsfiddle for this as well?

@nickdatum
Copy link
Contributor Author

Will do now. Just realised I forgot to copy over a line of code as well, which I'll also do now and submit a new pull request!

@nickdatum
Copy link
Contributor Author

@nickdatum
Copy link
Contributor Author

Pull request now made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants