Implemented Tailwind / Added Forms #48
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/App/App.css
Outdated
| justify-content: space-between; | ||
| padding-bottom: 5rem; |
There was a problem hiding this comment.
Making a note of this rule for min-height vs max-height and padding bottom bc it's working effectively on my branch with max height and no padding.
| @@ -89,8 +89,9 @@ | |||
| @media screen and (min-width: 1025px){ | |||
| .BreadListWrapper h2 { | |||
| margin-top: 2rem; | |||
| font-size: xx-large; | |||
| font-size: 2rem; | |||
| margin-bottom: 1rem; | |||
There was a problem hiding this comment.
This will be a merge conflict with the working code on my branch but since my styling has all migrated to the inline JSX with Tailwind, it should be easy to reconcile. If we need to change the font and margin top, we can adjust as needed.
| const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| const { name, value } = event.target; | ||
| setCredentials({ ...credentials, [name]: value }); | ||
| }; |
There was a problem hiding this comment.
Great job implementing this with TS!
There was a problem hiding this comment.
Great job creating the user account form in TypeScript and adding the GeoJSON. I have some concerns about the Tailwind and styling conflicting since we were working on the same components. I will resolve the merge conflicts and made note of the conflicting CSS that might need revisiting. Rn, the styling looks good on my side with significant margins and padding differing for the main and app components.
What kind of change does this PR introduce?
Feature description:
Checklist before requesting a review
What’s next:
Work on styling consistency across devices, integrate working breadbox