Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hoek to latest version to mitigate moderate vuln #4

Closed
arek-kwapis opened this issue Aug 1, 2018 · 3 comments
Closed

Update hoek to latest version to mitigate moderate vuln #4

arek-kwapis opened this issue Aug 1, 2018 · 3 comments

Comments

@arek-kwapis
Copy link

A current dependency, hoek version 2.16.1, has a moderate level vulnerability (MAID exploit) listed in the CVE database, which extends to repositories which rely on electron-acrylic as a dependency.

hoek should be updated to at least version 5.0.3 to resolve this issue

@23phy
Copy link
Owner

23phy commented Aug 1, 2018

Is this repo using hoek on of the dependencies?

@arek-kwapis
Copy link
Author

It appears so. running npm audit throws a wobbly and displays the vulnerability 4 times. I cannot find the files it links to, nor is hoek in my package-lock.json, despite node-gyp being there, and there is no other dependency (other than electron itself) so it cannot be another package causing this. Both github and npm pick up on this.

After cloning the repo and checking the audit, node-gyp has a SECOND moderate vuln from a dependency, stringstream. I have attached the screenshot along with the rest.

vuln2
vuln1
vuln3

this appears to be a known issue on hoek, having multiple issues deal with the exact same thing: hoek showing up as vulnerable, but not found in any files. I will attempt to use the fix provided of installing then removing hoek, then doing an update

@23phy
Copy link
Owner

23phy commented Jan 19, 2019

Yep, the issue has been solved.

@23phy 23phy closed this as completed Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants