Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sql do the work to find 24 random users with pull requests #1664

Merged
merged 1 commit into from Dec 2, 2016

Conversation

andrew
Copy link
Member

@andrew andrew commented Dec 2, 2016

We're currently loading 200 user records and 200 org records into memory on every homepage request, this just randomly picks from any users who have sent at least 1 pr in SQL 馃殔

@nodunayo
Copy link
Contributor

nodunayo commented Dec 2, 2016

Did you do any benchmarking? :P

@nodunayo nodunayo closed this Dec 2, 2016
@nodunayo nodunayo reopened this Dec 2, 2016
@nodunayo nodunayo merged commit 5986dfe into master Dec 2, 2016
@andrew
Copy link
Member Author

andrew commented Dec 2, 2016

Nope, but you've merged it already so...

1250991947631

@andrew andrew deleted the faster-homepage branch December 2, 2016 18:30
@andrew
Copy link
Member Author

andrew commented Dec 2, 2016

Just deployed it, we'll let newrelic do the benchmarking ;)

@nodunayo
Copy link
Contributor

nodunayo commented Dec 2, 2016

Ahaha, great!

@andrew
Copy link
Member Author

andrew commented Dec 3, 2016

screen shot 2016-12-03 at 9 47 30 am

馃憣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants