Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update gift dropdown after pull requests sync #574
This is a fix for issue #567 (by adding some data-attributes to the .pull_request elements and using that data to populate the dropdown after a sync) - but I'm not happy with it!
The big problem with it is the #TODO in the dashboard_spec.rb: there's a sleep in there, because I can't seem to convince Capybara to wait for the spinner to disappear. I'm pretty rusty with Rails, though, so I'm sure I'm just missing something obvious - can anyone point me in the right direction? I'll very happily update this PR if so.
As the comment says, I've tried
As I say, any pointers gratefully received!