Update configuration reporting with work and break time #189

TheRustyPickle · 2023-04-30T20:03:03Z

Added work and break time specifications on the configuration report
get_slack_channel was being called twice instead of get_slack_token in the report. This was also fixed. Resolves [improvement] Generate config report considering newly added configurations #186.

Lines 46 to 52 in 16c0687

    
           let slack_channel_message = match config.get_slack_channel() { 
        
               Some(_) => Report::new("O", "slack_channel"), 
        
               None => Report::new("X", "slack_channel") 
        
                   .update_reason(&ConfigurationError::SlackConfigNotFound), 
        
           }; 
        
           let slack_token_message = match config.get_slack_channel() {

24seconds

LGTM! Thank you for the contribution!

24seconds · 2023-05-03T07:26:52Z

src/report.rs

@@ -49,7 +49,7 @@ pub fn generate_configuration_report(
            .update_reason(&ConfigurationError::SlackConfigNotFound),
    };

-    let slack_token_message = match config.get_slack_channel() {
+    let slack_token_message = match config.get_slack_token() {


TheRustyPickle added 2 commits May 1, 2023 01:54

Update reporting

73f5383

Update

be36919

24seconds self-requested a review May 3, 2023 07:23

24seconds assigned TheRustyPickle May 3, 2023

24seconds added bug Something isn't working enhancement New feature or request labels May 3, 2023

24seconds approved these changes May 3, 2023

View reviewed changes

24seconds merged commit 2ebb2b9 into 24seconds:main May 3, 2023
3 checks passed

TheRustyPickle deleted the update-config-report branch May 3, 2023 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update configuration reporting with work and break time #189

Update configuration reporting with work and break time #189

TheRustyPickle commented Apr 30, 2023 •

edited

24seconds left a comment

24seconds May 3, 2023

	let slack_channel_message = match config.get_slack_channel() {
	Some(_) => Report::new("O", "slack_channel"),
	None => Report::new("X", "slack_channel")
	.update_reason(&ConfigurationError::SlackConfigNotFound),
	};

	let slack_token_message = match config.get_slack_channel() {

Update configuration reporting with work and break time #189

Update configuration reporting with work and break time #189

Conversation

TheRustyPickle commented Apr 30, 2023 • edited

24seconds left a comment

Choose a reason for hiding this comment

24seconds May 3, 2023

Choose a reason for hiding this comment

TheRustyPickle commented Apr 30, 2023 •

edited