Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save speed/pitch for song #307

Open
Monoxide8969 opened this issue May 23, 2024 · 2 comments
Open

Save speed/pitch for song #307

Monoxide8969 opened this issue May 23, 2024 · 2 comments
Labels
enhancement New feature or request prio:low

Comments

@Monoxide8969
Copy link

Add a "save for this song" button in the Speed & pitch dialog popup, to the left of the confirm button.
This remembers the setting for that single song. That's it.

A couple of side stuff from ux perspective

  • How the sliders are set on the screen (the "global" speed/pitch setting) should be prioritized over the custom speed/pitch preset. (I hope I made myself clear on this one, lmk if I need to elaborate on this)

  • if speed/pitch are set to 0, the "save for this song" button becomes "reset for this song"

  • if a song has a custom speed/pitch assigned to it, the little gauge indicator should appear somewhere in the player, maybe on top of the song title, or where i put the red x (just a couple ideas). Clicking on it may or may not pull up the speed/pitch menu, I don't know if it's best to leave it as an indicator or making it a button.

Board

I realize this is pretty niche, but I'd like to see it implemented.

@Monoxide8969 Monoxide8969 added the enhancement New feature or request label May 23, 2024
@25huizengek1
Copy link
Owner

I like the idea, I'm not sure if this makes sense, as it would complicate the menus even further. I'll put this on low prio.

@Monoxide8969
Copy link
Author

I don't think it would complicate menus more than #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:low
Projects
None yet
Development

No branches or pull requests

2 participants