WHISTLE-717: allow caller id to come from stale views, and log when t…

…he lookup failes with the reason
2600hz · Nov 12, 2011 · ad6820e · ad6820e
1 parent 8d22de9
commit ad6820e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/whistle_apps/apps/callflow/src/cf_attributes.erl b/whistle_apps/apps/callflow/src/cf_attributes.erl
@@ -88,7 +88,7 @@ caller_id(CIDType, DeviceId, OwnerId, #cf_call{account_id=AccountId, cid_number=
                       Property -> Property
                   end,
             CIDNumber = wh_json:get_value(<<"number">>, CID, Num),
-            CIDName = wh_json:get_value(<<"name">>, CID, Num),
+            CIDName = wh_json:get_value(<<"name">>, CID, Name),
             ?LOG("using caller id ~s '~s'", [CIDNumber, CIDName]),
             {CIDNumber, CIDName}
     end.
@@ -257,13 +257,14 @@ fetch_attributes(Attribute, Expires, #cf_call{account_db=Db}) ->
         {ok, Attributes} ->
             Attributes;
         {error, not_found} ->
-            case couch_mgr:get_all_results(Db, get_view(Attribute)) of
+            case couch_mgr:get_results(Db, get_view(Attribute), [{<<"stale">>, <<"ok">>}]) of
                 {ok, JObj} ->
                     Properties = [{wh_json:get_value(<<"key">>, Property), wh_json:get_value(<<"value">>, Property)}
                                   || Property <- JObj],
                     wh_cache:store({cf_attribute, Db, Attribute}, Properties, Expires),
                     Properties;
-                {error, _} ->
+                {error, R} ->
+                    ?LOG("unable to fetch attribute ~s: ~p", [Attribute, R]),
                     []
             end
     end.