KAZOO-5262: Make number search timeout configurable #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenollp
suggested changes
Jan 4, 2017
| @@ -57,6 +57,8 @@ | |||
|
|
|||
| -define(POLLING_INTERVAL, 5000). | |||
|
|
|||
| -define(NUMBER_SEARCH_TIMEOUT, kapps_config:get_integer(?KNM_CONFIG_CAT, <<"number_search_timeout">>, 5000)). | |||
There was a problem hiding this comment.
Can you suffix this to signify milliseconds? ie "number_search_timeout_ms"
|
I have experienced the same issue. Thanks for this patch! :) |
|
@fenollp Hi Pierre! There is another question raised with Telnyx module. Number lookup returns numbers with different activation charges and monthly fees costs. Since, at the moment, Kazoo charges numbers fees depending on configured service plans, there could be some impact from business point of view :)) Do you have any ideas about it already? |
|
Look at the second line of the table:
|
fenollp
approved these changes
Jan 4, 2017
|
Merging this. Let's discuss over at #3081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing Telnyx as a number provider atm.
Sometimes Telnyx processes its number lookup slightly longer than 5 seconds.
Because of 5000 number search hardcoded timeout, Kazoo provides empty result...