Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PISTON-542: add the cf_acdc_wait_time module #4619

Closed
wants to merge 7 commits into from

Conversation

danielfinke
Copy link
Member

No description provided.

## Acdc Wait Time

### About Acdc Wait Time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a one-liner or something here to describe the intended usage?

@danielfinke
Copy link
Member Author

@jamesaimonetti added documentation.
Do you have any thoughts around policy for the copyright for completely new modules? (see the failure in CircleCI)

@jamesaimonetti
Copy link
Member

@danielfinke yeah, that's annoying. @icehess can you take a look at the edocify stuff to not overwrite alternative copyright names?

Conflicts:
	applications/acdc/src/acdc_stats.erl
	applications/acdc/src/cf_acdc_wait_time.erl
	applications/callflow/doc/acdc_wait_time.md
	applications/callflow/doc/ref/acdc_wait_time.md
	applications/crossbar/priv/api/swagger.json
	applications/crossbar/priv/couchdb/schemas/callflows.acdc_wait_time.json
@noahmehl
Copy link
Contributor

As discussed on the community call today, we're hoping that @icehess can help with updating the edocify stuff to not overwrite the alternative copyright names.

@icehess
Copy link
Contributor

icehess commented May 11, 2018

@danielfinke @noahmehl edocify script is updated. You can now rebase to master.

@noahmehl
Copy link
Contributor

noahmehl commented Jun 8, 2018

@icehess thanks for getting that done :) @danielfinke can you please rebase :) ?

jamesaimonetti pushed a commit that referenced this pull request Jun 11, 2018
PISTON-542: move cf_acdc_wait_time module into acdc app

PISTON-542: fixes for master, remove custom KVs code

PISTON-542: make code_checks

PISTON-542: make docs

PISTON-542: add documentation of cf_acdc_wait_time module purpose

PISTON-556: acdc average wait time req custom window

Conflicts:
	applications/acdc/src/acdc_stats.erl
	applications/acdc/src/cf_acdc_wait_time.erl
	applications/callflow/doc/acdc_wait_time.md
	applications/callflow/doc/ref/acdc_wait_time.md
	applications/crossbar/priv/api/swagger.json
	applications/crossbar/priv/couchdb/schemas/callflows.acdc_wait_time.json

address edoc
@jamesaimonetti
Copy link
Member

@noahmehl @danielfinke there was only a small edoc-related change to make the build work. Merged!

@noahmehl
Copy link
Contributor

@jamesaimonetti You're the best!!!

@danielfinke
Copy link
Member Author

@jamesaimonetti thanks
@noahmehl I'm going to make some changes to this code very soon though, so don't get too attached. I don't believe there are too many breaking changes

@danielfinke danielfinke deleted the master-pr-cf-acdc-wait-time branch June 19, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants