KAZOO-5800: Re-check for call restrictions after shortdial correction #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harenson
force-pushed
the
KAZOO-5800
branch
2 times, most recently
from
f2eb69e
to
3e6bc17
Compare
|
Can you rebase and recheck this functionality? Let's get it merged once rebased |
|
Done :) |
| {'error', _R} -> | ||
| Call; | ||
| {'ok', JObj} -> | ||
| CallRestriction = kz_json:get_value(<<"call_restriction">>, JObj), |
There was a problem hiding this comment.
Use the more specific getters when you can: get_json_value/2 (maybe with a default kz_json:new()?) and get_ne_binary_value/2 on the next line.
| @@ -77,6 +77,9 @@ | |||
| "Custom-SIP-Headers": { | |||
| "type": "object" | |||
| }, | |||
| "Denied-Call-Restrictions": { | |||
There was a problem hiding this comment.
Are they really a string? Or should this be an object? You can hint at it in the kapi module using a validator or you can manually correct this schema.
jamesaimonetti
force-pushed
the
KAZOO-5800
branch
from
0684268
to
75c9e48
Compare
jamesaimonetti
force-pushed
the
KAZOO-5800
branch
2 times, most recently
from
b5046cd
to
b5cff06
Compare
|
@harenson i refactored a bit; mind checking if things are still working on your tests? Will merge if you agree :) |
…#4675) refactor a bit refactor to named function fix function arity
jamesaimonetti
force-pushed
the
KAZOO-5800
branch
from
b5cff06
to
77f0291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.