PISTON-1289: create_caller_id_name_if_undefined #6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bradfordben Hi, can't you do this on the client side before submitting ? |
|
@lazedo Im not sure what you mean? Maybe im missing something? So for an example where a kazoo device calls some endpoint B, Without the change if the kazoo device sets the caller id on the A leg it wont be used on the B leg as kazoo generates the default username if no caller id is set on the endpoint and uses that caller id name on the B leg. |
'create_caller_id_name_if_undefined' to allow the creation of the users caller id name to be optional when no caller id is defined.
bradfordben
force-pushed
the
upstream-4.3-create-caller-id-name-if-undefined
branch
from
35df397
to
9f035fe
Compare
should_ to create_caller_id_name_if_undefined attribute
should_create_caller_id_name_if_undefined to should_create_caller_id
bradfordben
force-pushed
the
upstream-4.3-create-caller-id-name-if-undefined
branch
from
92b4407
to
474d16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new attribute to the users object 'create_caller_id_name_if_undefined' to allow the creation of the users
caller id name to be optional when no caller id is defined.
Kazoo 5: https://github.com/2600hz/kazoo-core/pull/269 and https://github.com/2600hz/kazoo-crossbar/pull/190