Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] MSTR-286: Fix issue where expired credit cards are set to default #1146

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

pcandia
Copy link
Contributor

@pcandia pcandia commented Mar 20, 2024

No description provided.

@pcandia pcandia self-assigned this Mar 20, 2024
guillegr123
guillegr123 previously approved these changes Mar 20, 2024
Copy link
Contributor

@guillegr123 guillegr123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Due to time contsraints, only if possible, include the block for requestPaymentMethod in a monster.waterfall sequence, in order to avoid nesting too many callbacks.

@pcandia pcandia merged commit ebe5902 into 5.3 Mar 20, 2024
1 check passed
@pcandia pcandia deleted the MSTR-286-2-5.3 branch March 20, 2024 21:29
pcandia added a commit that referenced this pull request Mar 20, 2024
…lt (#1146)

* MSTR-286: Fix issue where expired credit cards are set to default

* Add fixes basded on code review
pcandia added a commit that referenced this pull request May 16, 2024
…lt (#1146)

* MSTR-286: Fix issue where expired credit cards are set to default

* Add fixes basded on code review
pcandia added a commit that referenced this pull request May 20, 2024
…lt (#1146)

* MSTR-286: Fix issue where expired credit cards are set to default

* Add fixes basded on code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants