Resolve lineheight units warning #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajsaunge
changed the title
gewfy
previously approved these changes
Aug 18, 2022
gewfy
reviewed
Aug 18, 2022
| @@ -38,6 +38,7 @@ export default StyleSheet.create({ | |||
| color: COLORS.GREY, | |||
| fontSize: 20, | |||
| lineHeight: 26, | |||
| padding: 1, | |||
There was a problem hiding this comment.
Oh thanks, I'll remove it 😬
gewfy
reviewed
Aug 18, 2022
| }, | ||
| const SafeAreaViewWrapper = styled(SafeAreaView)({flex: 1}); | ||
|
|
||
| const ScrollViewWrapper = styled(ScrollView)({flex: 1}); |
There was a problem hiding this comment.
You actually don't need to import components from react-native. Here you can instead write styled.ScrollView({flex: 1});
…9ki/29k into remove-stylesheet-and-fix-unit-warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of stylesheet create where possible
Removes style objects to use styled components
Adds px units for lineheight to get rid of units warning
Closes #143 #104