Optimize code

2Fake · May 7, 2023 · 2ba7e7b · 2ba7e7b
1 parent f5b7297
commit 2ba7e7b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/devolo_home_control_api/devices/gateway.py b/devolo_home_control_api/devices/gateway.py
@@ -31,13 +31,9 @@ def __init__(self, gateway_id: str, mydevolo_instance: Mydevolo) -> None:
         self.local_user = self._mydevolo.uuid()
         self.local_passkey = details["localPasskey"]
         self.external_access = details.get("externalAccess")
+        self.timezone = tz.gettz(details["location"].get("timezone") or self._mydevolo.get_timezone()) or timezone.utc
         self.firmware_version = details.get("firmwareVersion")
 
-        if details["location"]:
-            self.timezone = tz.gettz(details["location"]["timezone"]) or timezone.utc
-        else:
-            self.timezone = tz.gettz(self._mydevolo.get_timezone()) or timezone.utc
-
         try:
             self.full_url: Optional[str] = self._mydevolo.get_full_url(self.id)
         except GatewayOfflineError:

diff --git a/devolo_home_control_api/mydevolo.py b/devolo_home_control_api/mydevolo.py
@@ -80,8 +80,7 @@ def get_gateway(self, gateway_id: str) -> Dict[str, Any]:
         except WrongUrlError:
             self._logger.error("Could not get full URL. Wrong gateway ID used?")
             raise
-        if details["location"]:
-            details["location"] = self._call(details["location"])
+        details["location"] = self._call(details["location"]) if details["location"] else {}
         return details
 
     def get_full_url(self, gateway_id: str) -> str:

diff --git a/tests/snapshots/test_mydevolo.ambr b/tests/snapshots/test_mydevolo.ambr
@@ -13,7 +13,8 @@
       'href': 'string',
     }),
     'localPasskey': '6b96ad097aa389209f1ceeaed6fe7029',
-    'location': None,
+    'location': dict({
+    }),
     'name': 'DVT Lab 1409301750000598',
     'partner': 'string',
     'role': 'user',