Broken down internals (modules per "feature") #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
approved these changes
Apr 23, 2022
paulo-ferraz-oliveira
changed the title
|
We can wait until after the training 😄 (or not merge, if you prefer, even; I don't mind seeing pull requests rejected - they start out by being possibilities, to me). I'll keep this here (unmerged), for the time being... For 0.1.0 (the training version, I just wanna have some examples ready, as well as the documentation as a |
paulo-ferraz-oliveira
force-pushed
the
feature/broken-down-internals
branch
from
2e5871e
to
92a499e
Compare
|
Updated as per most recent changes (lest it becomes too outdated). |
I get rid of the caveat by making sure a non matching mocker dies
| @@ -148,52 +102,49 @@ run_expects(Message, Expects) -> | |||
| maps:fold(fun (_Id, _Expect, {{'$nuntius', match}, _} = Result) -> | |||
| Result; | |||
| (_Id, Expect, {'$nuntius', nomatch}) -> | |||
| try | |||
| {{'$nuntius', match}, Expect(Message)} | |||
| try Expect(Message) of | |||
There was a problem hiding this comment.
Maybe this approach is also valid in bringing more clarity to the function_clause caveat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.
If you feel we should also sort the function definitions, I'm up for it.
I usually keep the "internal" functions next to whatever calls them (it seems you do the same), so I would be careful to take those along with the "moved" functions.
Let me know.