don't warn on ignored directory symlinks

lib/src/validator/gitignore.dart

@@ -46,10 +46,8 @@ class GitignoreValidator extends Validator {
         beneath: beneath,
         listDir: (dir) {
           var contents = Directory(resolve(dir)).listSync();
-          return contents
-              .where((e) => !(linkExists(e.path) && dirExists(e.path)))
-              .map((entity) => p.posix
-                  .joinAll(p.split(p.relative(entity.path, from: root))));
+          return contents.map((entity) =>
+              p.posix.joinAll(p.split(p.relative(entity.path, from: root))));
         },
         ignoreForDir: (dir) {
           final gitIgnore = resolve('$dir/.gitignore');
@@ -58,7 +56,10 @@ class GitignoreValidator extends Validator {
           ];
           return rules.isEmpty ? null : Ignore(rules);
         },
-        isDir: (dir) => dirExists(resolve(dir)),
+        isDir: (dir) {
+          final resolved = resolve(dir);
+          return dirExists(resolved) && !linkExists(resolved);
+        },
       ).map((file) {
         final relative = p.relative(resolve(file), from: entrypoint.root.dir);
         return Platform.isWindows

test/package_list_files_test.dart

@@ -12,6 +12,7 @@ import 'package:test/test.dart';
 
 import 'descriptor.dart' as d;
 import 'test_pub.dart';
+import 'validator/utils.dart';
 
 late String root;
 Entrypoint? entrypoint;
@@ -45,14 +46,7 @@ void main() {
         ]));
   });
 
-  // On windows symlinks to directories are distinct from symlinks to files.
-  void createDirectorySymlink(String path, String target) {
-    if (Platform.isWindows) {
-      Process.runSync('cmd', ['/c', 'mklink', '/D', path, target]);
-    } else {
-      Link(path).createSync(target);
-    }
-  }
+
 
   test('throws on directory symlinks', () async {
     await d.dir(appPath, [

test/validator/gitignore_test.dart

@@ -10,6 +10,7 @@ import 'package:test/test.dart';
 
 import '../descriptor.dart' as d;
 import '../test_pub.dart';
+import 'utils.dart';
 
 Future<void> expectValidation(
   error,
@@ -102,4 +103,24 @@ void main() {
     await expectValidation(contains('Package has 0 warnings.'), 0,
         workingDirectory: packageRoot);
   });
+
+  test('Should consider symlinks to be valid files and not list them as gitignored', () async {
+    final git = d.git(appPath, [
+      ...d.validPackage.contents,
+      d.dir('dir_with_symlink', [
+        d.file('.pubignore', '/symlink'),
+      ]),
+    ]);
+    await git.create();
+    final packageRoot = p.join(d.sandbox, appPath);
+    await pubGet(
+        environment: {'_PUB_TEST_SDK_VERSION': '1.12.0'},
+        workingDirectory: packageRoot);
+    createDirectorySymlink(
+        p.join(d.sandbox, appPath, 'dir_with_symlink', 'symlink'), '..');
+    git.commit();
+
+    await expectValidation(contains('Package has 0 warnings.'), 0,
+        workingDirectory: packageRoot);
+  });
 }

test/validator/utils.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:io';
+
 import 'package:test/test.dart';
 
 import '../test_pub.dart';
@@ -16,3 +18,12 @@ Future<void> expectValidation(ValidatorCreator fn,
   expect(validator.warnings, warnings ?? isEmpty);
   expect(validator.hints, hints ?? isEmpty);
 }
+
+// On windows symlinks to directories are distinct from symlinks to files.
+void createDirectorySymlink(String path, String target) {
+  if (Platform.isWindows) {
+    Process.runSync('cmd', ['/c', 'mklink', '/D', path, target]);
+  } else {
+    Link(path).createSync(target);
+  }
+}