don't follow links

2ZeroSix · Feb 3, 2022 · f371314 · f371314
1 parent 47bb026
commit f371314
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/lib/src/package.dart b/lib/src/package.dart
@@ -245,7 +245,7 @@ class Package {
     return Ignore.listFiles(
       beneath: beneath,
       listDir: (dir) {
-        var contents = Directory(resolve(dir)).listSync(recursive: true);
+        var contents = Directory(resolve(dir)).listSync(followLinks: false);
         if (!recursive) {
           contents = contents.where((entity) => entity is! Directory).toList();
         }

diff --git a/lib/src/validator/gitignore.dart b/lib/src/validator/gitignore.dart
@@ -45,7 +45,7 @@ class GitignoreValidator extends Validator {
       final unignoredByGitignore = Ignore.listFiles(
         beneath: beneath,
         listDir: (dir) {
-          var contents = Directory(resolve(dir)).listSync();
+          var contents = Directory(resolve(dir)).listSync(followLinks: false);
           return contents.map((entity) =>
               p.posix.joinAll(p.split(p.relative(entity.path, from: root))));
         },

diff --git a/test/package_list_files_test.dart b/test/package_list_files_test.dart
@@ -118,7 +118,8 @@ void main() {
           (e) => e.message,
           'message',
           contains(
-              'Pub does not support publishing packages with non-resolving symlink:'),
+            'Pub does not support publishing packages with directory symlinks',
+          ),
         ),
       ),
     );