Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

WhEditable bugs fix #82

Closed
wants to merge 5 commits into from
Closed

WhEditable bugs fix #82

wants to merge 5 commits into from

Conversation

neowutran
Copy link
Contributor

Normally, it should fix "WhEditable bugs." This is my first pull request, I hope it will work.

@kudzuu
Copy link

kudzuu commented Nov 12, 2013

thx

will be nice as well to provide ref. number of issue (#59) in commit message

parent::renderFilterCell();
return;
}
}*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it needs to be commented?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that if its not required to be there, it should be removed, not commented out

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, agree

@antiyanky
Copy link

Hola, ya realice todos los cambios, y muchos de los errores se fueron, el problema es que al editar cualquier campo, me tira el siguiente error:

https://www.dropbox.com/s/629p1h6ipe4rfx7/1.png
https://www.dropbox.com/s/i731wjp9nfk6276/error2.png

por favor necesito de su ayuda, muchas gracias! (mi mail es arenzo@neutrocode.com)

@tonydspaniard
Copy link
Member

@antiyanky @kudzuu @neowutran sorry for late reply... will try to review and check asap

@tonydspaniard
Copy link
Member

@antiyanky disculpa pero necesito más datos. Parece que es un problema de tus acciones.

@tonydspaniard
Copy link
Member

Had to merge it via command line... Thanks @neowutran

@tonydspaniard tonydspaniard mentioned this pull request Mar 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants