Conversation
thx will be nice as well to provide ref. number of issue (#59) in commit message |
parent::renderFilterCell(); | ||
return; | ||
} | ||
}*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it needs to be commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is that if its not required to be there, it should be removed, not commented out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, agree
Hola, ya realice todos los cambios, y muchos de los errores se fueron, el problema es que al editar cualquier campo, me tira el siguiente error: https://www.dropbox.com/s/629p1h6ipe4rfx7/1.png por favor necesito de su ayuda, muchas gracias! (mi mail es arenzo@neutrocode.com) |
@antiyanky @kudzuu @neowutran sorry for late reply... will try to review and check asap |
@antiyanky disculpa pero necesito más datos. Parece que es un problema de tus acciones. |
Had to merge it via command line... Thanks @neowutran |
Normally, it should fix "WhEditable bugs." This is my first pull request, I hope it will work.