Fix for blur close to 0.

2d-inc · Dec 10, 2019 · 788c662 · 788c662
1 parent f0b24f4
commit 788c662
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 9 deletions.
diff --git a/flare_flutter/CHANGELOG.md b/flare_flutter/CHANGELOG.md
@@ -1,3 +1,7 @@
+## [1.8.1] - 2019-12-09 19:33:06
+
+- Disable blur effects if they are less than a certain threshold. Skia seems to drop the whole layer if it's too close to zero (but not zero).
+
 ## [1.8.0] - 2019-12-05 17:34:01
 
 - Support for layer effects including masking, drop shadows, inner shadows, and blurs.

diff --git a/flare_flutter/lib/flare.dart b/flare_flutter/lib/flare.dart
@@ -1305,6 +1305,14 @@ class FlutterActorInnerShadow extends ActorInnerShadow {
   ui.BlendMode blendMode;
 }
 
+ui.ImageFilter _blurFilter(double x, double y) {
+  double bx = x.abs() < 0.1 ? 0 : x;
+  double by = y.abs() < 0.1 ? 0 : y;
+  return bx == 0 && by == 0
+      ? null
+      : ui.ImageFilter.blur(sigmaX: bx, sigmaY: by);
+}
+
 class FlutterActorLayerEffectRenderer extends ActorLayerEffectRenderer
     with FlutterActorDrawable {
   @override
@@ -1320,8 +1328,7 @@ class FlutterActorLayerEffectRenderer extends ActorLayerEffectRenderer
     if (blur?.isActive ?? false) {
       baseBlurX = blur.blurX;
       baseBlurY = blur.blurY;
-      layerPaint.imageFilter =
-          ui.ImageFilter.blur(sigmaX: baseBlurX, sigmaY: baseBlurY);
+      layerPaint.imageFilter = _blurFilter(baseBlurX, baseBlurY);
     }
 
     if (dropShadows.isNotEmpty) {
@@ -1337,9 +1344,8 @@ class FlutterActorLayerEffectRenderer extends ActorLayerEffectRenderer
         canvas.translate(dropShadow.offsetX, dropShadow.offsetY);
         var shadowPaint = Paint()
           ..color = layerColor
-          ..imageFilter = ui.ImageFilter.blur(
-              sigmaX: dropShadow.blurX + baseBlurX,
-              sigmaY: dropShadow.blurY + baseBlurY)
+          ..imageFilter = _blurFilter(
+              dropShadow.blurX + baseBlurX, dropShadow.blurY + baseBlurY)
           ..colorFilter = ui.ColorFilter.mode(
               ui.Color.fromRGBO(
                   (color[0] * 255.0).round(),
@@ -1382,9 +1388,8 @@ class FlutterActorLayerEffectRenderer extends ActorLayerEffectRenderer
           ..color = layerColor
           ..blendMode =
               extraBlendPass ? ui.BlendMode.srcIn : ui.BlendMode.srcATop
-          ..imageFilter = ui.ImageFilter.blur(
-              sigmaX: innerShadow.blurX + baseBlurX,
-              sigmaY: innerShadow.blurY + baseBlurY)
+          ..imageFilter = _blurFilter(
+              innerShadow.blurX + baseBlurX, innerShadow.blurY + baseBlurY)
           ..colorFilter = ui.ColorFilter.mode(
               ui.Color.fromRGBO(
                   (color[0] * 255.0).round(),

diff --git a/flare_flutter/pubspec.yaml b/flare_flutter/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flare_flutter
 description: Vector design and runtime animation for Flutter.
-version: 1.8.0
+version: 1.8.1
 author: "Rive Team <info@rive.app>"
 homepage: https://github.com/2d-inc/Flare-Flutter
 environment: